You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OK here we are. Only one warning by clang-tidy on my PR.
Even better: it's 100% relevant. I was concerned by line 2749 ContourPlot *plot =new ContourPlot(0,0);//m_contourPlot; //TODO leaking ? and wrote the comment before looking at clang-tidy outputs.
I recommend merging #296 (not this one) as it should not be too noisy and still makes good review.
as I explained there is a very tiny bit of warning leaking on unmodified code: #296 (comment)
point 3: About half of the clang comments were on code that you hadn't modified. It seems maybe it was either all code in the modified file or it was code near the edits. I'm not sure which.
What it does basically is a diff. If it shows in diff then it's reviewed. If you look again you will see most comments are on modified code (even if modification is only a space change on this line).
Very few are indeed on unmodified code but very near. This is from how diff works.
I confirm the whole file is not reviewed. This has been tested and verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what would it show in #263